-
-
Notifications
You must be signed in to change notification settings - Fork 347
Add callback argument to render() #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe we can do the same with |
…s the right way - and had to change `defer` to `setTimeout` for now, as I'm not sure if `requestAnimationFrame` even works with `jsdom` in the first place?
…s the right way - and had to change `defer` to `setTimeout` for now, as I'm not sure if `requestAnimationFrame` even works with `jsdom` in the first place?
Hey, let's continue to talk about this. For our test, I think we can add callbacks, but I'm sorry it may take a few days because our school Internet is not work yet. |
I added new Promise((resolve, reject) => {
options.resolve = resolve
render(<App />, root)
}) It is set by |
Looks like this is done :-) |
I just noticed in React docs that there's a third argument
callback
in ReactDOM'srender()
function:According to the docs:
This would be very useful for testing, at least.
What do you think about adding support for this?
The text was updated successfully, but these errors were encountered: