Rework Release Creation #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Github build is building targets in separate VMs, it does not use the target-list in the Makefile, but holds its own copy instead. This change moves the target list into a new file called "targets" which is then used by the Makefile as well as the Github workflow.
awlx
approved these changes
Feb 5, 2023
GoliathLabs
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports aca0f24 and it reworks the release action to handle release created in the Github UI gracefully.
Using the new
download-artifact@v3together withsoftprops/action-gh-release@v1also allows us to drop the second Github Action matrix run and only have a single instance.Here is an examplary run: https://github.com/grische/site-ffm/actions/runs/4096766822