Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to stable 2409 with Rust 1.81 and EVM enhancements #976

Merged
merged 22 commits into from
Feb 4, 2025

Conversation

tsenovilla
Copy link
Collaborator

@tsenovilla tsenovilla commented Jan 31, 2025

User description

Bump dependencies to 2409 and related updates


PR Type

Enhancement, Bug fix, Tests


Description

  • Updated SDK dependencies to stable version 2409, including Rust toolchain upgrade to 1.81.

  • Introduced GasLimitStorageGrowthRatio parameter and related configurations in EVM pallet.

  • Fixed Clippy warnings and added #![allow(clippy::manual_inspect)] to address false positives.

  • Enhanced test coverage for storage growth ratio and other configurations.


Changes walkthrough 📝

Relevant files
Enhancement
4 files
lib.rs
Added `AddressMapping` and updated dispatch calls.             
+19/-18 
evm.rs
Added `GasLimitStorageGrowthRatio` and updated EVM configurations.
+20/-2   
mod.rs
Removed `DenyUnsafe` and adjusted RPC dependencies.           
+3/-5     
relay_chain.rs
Added NFT-related configurations and teleporters.               
+6/-1     
Configuration changes
2 files
service.rs
Updated executor configurations and network setup.             
+13/-11 
command.rs
Adjusted RPC endpoint handling and hardware benchmarking.
+8/-13   
Tests
7 files
mock.rs
Updated mock configurations for EVM.                                         
+4/-3     
mock.rs
Updated mock configurations for `GasLimitStorageGrowthRatio`.
+3/-1     
mock.rs
Added `GasLimitStorageGrowthRatio` to mock configurations.
+3/-1     
mock.rs
Updated mock configurations for EVM.                                         
+3/-1     
mock.rs
Added `GasLimitStorageGrowthRatio` to mock configurations.
+3/-1     
tests.rs
Fixed balance lock assertions in tests.                                   
+2/-2     
mod.rs
Fixed balance lock assertions in XCM tests.                           
+2/-2     
Bug fix
7 files
lib.rs
Added Clippy allowance for `manual_inspect`.                         
+5/-0     
lib.rs
Added Clippy allowance for `manual_inspect`.                         
+6/-0     
lib.rs
Added Clippy allowance for `manual_inspect`.                         
+5/-0     
lib.rs
Added Clippy allowance for `manual_inspect`.                         
+5/-0     
lib.rs
Added Clippy allowance for `manual_inspect`.                         
+5/-0     
lib.rs
Added Clippy allowance for `manual_inspect`.                         
+2/-0     
benchmarking.rs
Added Clippy allowance for `multiple_bound_locations`.     
+3/-0     
Additional files
9 files
Cargo.toml +149/-148
laos.rs +1/-0     
mock.rs +1/-1     
benchmarking.rs +0/-1     
Cargo.toml +1/-1     
ethereum.rs +1/-1     
metadata15.golden +272/-332
rust-toolchain +2/-2     
Cargo.toml +3/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @asiniscalchi
    Copy link
    Member

    /describe

    @github-actions github-actions bot changed the title Chore/update sdk to stable 2409 Update SDK to stable 2409 with Rust 1.81 and EVM enhancements Jan 31, 2025
    Copy link

    PR Description updated to latest commit (1188ad1)

    precompiles/parachain-staking/src/mock.rs Outdated Show resolved Hide resolved
    @@ -47,9 +47,13 @@ parameter_types! {
    /// (max_extrinsic.ref_time() / max_extrinsic.proof_size()) / WEIGHT_PER_GAS
    /// )
    pub const GasLimitPovSizeRatio: u64 = 4;
    /// The amount of gas per storage (in bytes): BLOCK_GAS_LIMIT / BLOCK_STORAGE_LIMIT
    /// The current definition of BLOCK_STORAGE_LIMIT is 160 KB, resulting in a value of 91.
    pub const GasLimitStorageGrowthRatio: u64 = 91;
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    where this number comes from ?

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    let expected_storage_growth_ratio =
    BlockGasLimit::get().low_u64().saturating_div(block_storage_limit);

    @tsenovilla tsenovilla merged commit 8e6555d into main Feb 4, 2025
    11 checks passed
    @luispdm luispdm deleted the chore/update-sdk-to-stable-2409 branch February 10, 2025 13:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants