Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled binaries #33

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Update bundled binaries #33

merged 9 commits into from
Oct 15, 2024

Conversation

dex4er
Copy link
Collaborator

@dex4er dex4er commented Oct 13, 2024

  • kubectl 1.31.1
  • helm 3.16.2
  • k8s-proxy 1.1.0

The default URL for kubectl is changed to https://dl.k8s.io/release/ (current official) as the old one does not have newer versions. It should fix the problem that bundled version of kubectl is used:

freelens: 2024-10-15T17:50:50.769Z pw:browser [pid=12716][out] info:    ┏ Downloading kubectl 1.30.5 from https://storage.googleapis.com/kubernetes-release/release/v1.30.5/bin/linux/amd64/kubectl to /tmp/lens-integration-testing/991f4e68-049c-4802-92f1-3812f7259c26/Freelens/binaries/kubectl/1.30.5/kubectl +42ms
freelens: 2024-10-15T17:50:50.769Z pw:browser [pid=12716][out] info:    ┗ [1] { timestamp: '15/10/2024 17:50:50' }
freelens: 2024-10-15T17:50:50.837Z pw:browser [pid=12716][out] error:   ┏ [KUBECTL]: failed to download kubectl Response code 404 (Not Found) +68ms
freelens: 2024-10-15T17:50:50.837Z pw:browser [pid=12716][out] error:   ┃ [ 1] HTTPError: Response code 404 (Not Found)
freelens: 2024-10-15T17:50:50.838Z pw:browser [pid=12716][out] error:   ┏ Failed to ensure kubectl, fallback to the bundled version +1ms

Additional patch:

  • Binaries downloader shows full URL now.

Closes #32

@dex4er dex4er self-assigned this Oct 13, 2024
@dex4er dex4er marked this pull request as draft October 13, 2024 20:57
@dex4er dex4er added this to the 0.1.1 milestone Oct 13, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 14, 2024

I'm not sure why the integration test breaks. I don't see any regression on my local setup on MacOS.

@dex4er
Copy link
Collaborator Author

dex4er commented Oct 14, 2024

Another regression:

freelens: 234 Error: Failed to download freelens-k8s-proxy.exe for windows/amd64: Error: https://github.com/freelensapp/freelens-k8s-proxy/releases/download/v1.1.0/freelens-k8s-proxy-windows-amd64: 404 Not Found

@dex4er
Copy link
Collaborator Author

dex4er commented Oct 14, 2024

Another regression:

freelens: 234 Error: Failed to download freelens-k8s-proxy.exe for windows/amd64: Error: https://github.com/freelensapp/freelens-k8s-proxy/releases/download/v1.1.0/freelens-k8s-proxy-windows-amd64: 404 Not Found

ok, this one is fixed

@dex4er
Copy link
Collaborator Author

dex4er commented Oct 15, 2024

Ok, I improved debugging and now I see

The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/runner/work/freelens/freelens/freelens/dist/linux-unpacked/chrome-sandbox is owned by root and has mode 4755.

@dex4er dex4er force-pushed the deps/bundled branch 2 times, most recently from 9ac91ad to 5e2f40d Compare October 15, 2024 13:23
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 15, 2024

sudo chown root:root freelens/dist/linux-unpacked/chrome-sandbox
sudo chmod 4755 freelens/dist/linux-unpacked/chrome-sandbox

did the trick

@dex4er dex4er marked this pull request as ready for review October 15, 2024 13:44
@dex4er dex4er requested a review from robertobandini October 15, 2024 13:46
@dex4er dex4er merged commit 2a44cbf into freelensapp:main Oct 15, 2024
5 checks passed
@dex4er dex4er deleted the deps/bundled branch October 15, 2024 18:34
@dex4er dex4er added the chore Minor updates without changing the logic in the code label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Minor updates without changing the logic in the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled kubectl should be up-to-date
1 participant