Speed up pam_ecryptfs testinfra check #7428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a noble migration, transmitting syslog back to the host so it can be searched can be pretty slow, so let's do it on the host. By using grep, we can escape the message we're looking for in a way that ensures our search doesn't match the error we're looking for. Since there's already a `.` in the message, use re.escape(), which turns it into `\.`, which obfuscates our grep.
|
Running into the same issue with |
36 tasks
cfm
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Tested in #7406 (comment) and passes CI modulo #7433. Thanks, @legoktm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
After a noble migration, transmitting syslog back to the host so it can be searched can be pretty slow, so let's do it on the host. By using grep, we can escape the message we're looking for in a way that ensures our search doesn't match the error we're looking for.
Since there's already a
.in the message, use re.escape(), which turns it into\., which obfuscates our grep.Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist