Viewport shouldn't always show a scrollbar #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overlooked this visual degradation that was introduced by the most recent accessibility related fixes. Fixes #6419
Codecov Report
@@ Coverage Diff @@
## develop #6422 +/- ##
========================================
Coverage 83.79% 83.79%
========================================
Files 62 62
Lines 4320 4320
Branches 525 525
========================================
Hits 3620 3620
Misses 575 575
Partials 125 125 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
zenmonkeykstop
approved these changes
May 3, 2022
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Because of a
body::afterelement used to pre-load a couple of images was visually hidden but still part of the DOM, the element forced the viewport to always show a scrollbar.I overlooked this visual degradation that was introduced by the most recent accessibility related changes to hide the element from screen-readers but forgot to position the element off-screen.
Fixes #6419
Testing