Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "securedrop-admin verify" kernel checks #5798

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Feb 17, 2021

Status

Ready for review

Description of Changes

Adds the new kernel version variables to molecule/testinfra/vars/prod*.yml.

Testing

Run securedrop-admin verify against a production Focal installation, on hardware or in VMs. There should be no AttributeError: 'Myvalues' object has no attribute 'grsec_version_focal' errors.

Deployment

Test only. Kinda. It will fix the configuration tests for production instances.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

conorsch
conorsch previously approved these changes Feb 17, 2021
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rmol. I should have tacked these on during review of #5712. Approving based on visual review, although will need a rebase once we figure out #5799.

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on latest develop to get CI passing. Approving based on prior review and visual diff. Good to merge when CI passes.

@emkll emkll merged commit 131f8f9 into develop Feb 18, 2021
@emkll emkll deleted the add-grsec-prod-versions branch February 18, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants