Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NUC7 hardware recommendation and relegates NUC5s and Mac minis to legacy #4431

Merged
merged 1 commit into from
May 31, 2019

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #3826.
Adds recommendation for NUC7i5BNH servers including information on securing hardware, removes Gigabyte Brix, moves NUC5s and Mac Mini to a previously recommended section for legacy support reasons.

Testing

Docs-only, review for clarity and correctness.

Deployment

Docs will be deployed by standard process when merged.

Checklist

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@eloquence
Copy link
Member

Overall looks great, a few small comments inline. Note that I only have the Mac Mini 2014 at hand, so can't verify any of the newly added technical details.

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #4431 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4431   +/-   ##
========================================
  Coverage    83.72%   83.72%           
========================================
  Files           44       44           
  Lines         2956     2956           
  Branches       321      321           
========================================
  Hits          2475     2475           
  Misses         404      404           
  Partials        77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cb9d1...9f28fdd. Read the comment docs.

@zenmonkeykstop zenmonkeykstop changed the title Adds NUC7 hardware recommendation, removes Brix and relegates NUC5s and Mac minis to legacy Adds NUC7 hardware recommendation and relegates NUC5s and Mac minis to legacy May 14, 2019
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built docs locally and reviewed the latest changes. Looks great!

@conorsch conorsch merged commit d164ece into freedomofpress:develop May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update hardware recommendations
6 participants