-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds NUC7 hardware recommendation and relegates NUC5s and Mac minis to legacy #4431
Adds NUC7 hardware recommendation and relegates NUC5s and Mac minis to legacy #4431
Conversation
Overall looks great, a few small comments inline. Note that I only have the Mac Mini 2014 at hand, so can't verify any of the newly added technical details. |
e0efb58
to
9f28fdd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4431 +/- ##
========================================
Coverage 83.72% 83.72%
========================================
Files 44 44
Lines 2956 2956
Branches 321 321
========================================
Hits 2475 2475
Misses 404 404
Partials 77 77 Continue to review full report at Codecov.
|
9f28fdd
to
24a8f9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built docs locally and reviewed the latest changes. Looks great!
Status
Ready for review
Description of Changes
Fixes #3826.
Adds recommendation for NUC7i5BNH servers including information on securing hardware, removes Gigabyte Brix, moves NUC5s and Mac Mini to a previously recommended section for legacy support reasons.
Testing
Docs-only, review for clarity and correctness.
Deployment
Docs will be deployed by standard process when merged.
Checklist
If you made changes to documentation:
make docs-lint
) passed locally