Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove BRIX from hardware recommendations; link from checklist #4075

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jan 25, 2019

Part of #3826
Resolves #3197

Given the lack of compatibility with the latest Mac Minis, this PR also makes it clear that they are not officially recommended hardware (while keeping the docs around for existing installs on the 2014 model).

Status

Ready for review

  • Doc linting (make docs-lint) passed locally

@@ -272,39 +272,13 @@ Specific Hardware Recommendations
Application and Monitor Servers
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We currently recommend the Gigabyte BRIX, Intel NUC, or Mac Mini for
SecureDrop servers.
We currently recommend the Intel NUC or Mac Mini for SecureDrop servers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to continue to recommend the Mac Mini, we need to be explicit about either year (2014) or model numbers, and probably make a point of saying the 2018 ones won't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of your changes in 2732588 we at least have a warning to that effect. I think we should keep the docs around (given the significant install base on Mic Mini), but we shouldn't say that "we currently recommend .. the Mac Mini". I'll take a stab at refactoring this section accordingly in a follow-up commit in this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now done; @zenmonkeykstop, could you take another look?

zenmonkeykstop
zenmonkeykstop approved these changes Jan 29, 2019
@@ -272,39 +272,13 @@ Specific Hardware Recommendations
Application and Monitor Servers
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We currently recommend the Gigabyte BRIX, Intel NUC, or Mac Mini for
SecureDrop servers.
We currently recommend the Intel NUC for SecureDrop servers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving out the Mac Mini altogether here is probably safest. it's not like the 2014s will be easily commercially available much longer.

@kushaldas
Copy link
Contributor

Kicking the failed updater-gui-tests.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good.

Sadly the screwdriver has $9.20 shipping cost to India :)

@kushaldas kushaldas merged commit 21de599 into develop Jan 29, 2019
@heartsucker heartsucker deleted the docs-hardware-cleanup branch February 27, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants