Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push grsecurity tasks to top of the install #2741

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Push grsecurity tasks to top of the install #2741

merged 1 commit into from
Dec 21, 2017

Conversation

msheiny
Copy link
Contributor

@msheiny msheiny commented Dec 13, 2017

Status

Ready for review

Description of Changes

Move grsec logic to the top of the play. Reasoning behind move is:

  • we want grsec on the box as fast as possible
  • we want a fail fast experience so if grsec kernel bombs out on a particular piece of hardware we arent also locking out the box and installing un-necessary networking

Fixes #2737

Testing

How should the reviewer test this PR?
Test a local prod run ... make sure CI is passing.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances. -- Nope
  2. New installs. -- Nope

@msheiny
Push grsecurity tasks to top of the install
4914c5d 
Fail fast on grsec tasks and make sure any subsequent tasks are run
through grsecurity's highly annoying locked down protections.
@msheiny msheiny requested a review from conorsch as a code owner December 13, 2017 20:34
@conorsch
Copy link
Contributor

Super straightforward. Will run through the paces in VMs to be absolutely sure.

conorsch
conorsch approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@redshiftzero redshiftzero merged commit bad5e2b into develop Dec 21, 2017
@redshiftzero redshiftzero deleted the GrsecUpTop branch December 21, 2017 15:30
@conorsch conorsch mentioned this pull request Mar 22, 2018
Closed
@conorsch conorsch mentioned this pull request Nov 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees
No one assigned
Labels
goals: Improve Ansible logic / smoother install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msheiny @conorsch @redshiftzero