-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source interface UX improvements #1534
Conversation
Thanks for this feedback @ninavizz! I'll modify this PR to make this change. |
No biggie—I'm creating a single new "issue" for all my 0.4 reccos, with each tweak numbered—so that you and @fowlslegs can more easily reference stuff in PRs. (and yes, am clearly labeling it as a reference-only document, that you and noah need to cite items on for them to be included into any builds) :) |
Great - thanks for doing that @ninavizz! |
I was going to make the same comment on the button location and color scheme, but @ninavizz beat me to it 😸 It's such a simple PR, but it would still be nice to add a functional test that clicks it during a upload and makes sure it does it's job to prevent against future regressions. |
e94c66a
to
c95e9e6
Compare
c95e9e6
to
5f3b559
Compare
I've modified this PR following the detailed guidance provided in #1536 and implemented a few more of the items from there:
Also added functional tests for the new "Cancel" buttons on Screenshots of the login and submit pages (note that the formatting of the button text as caps and the headlines is covered by @heartsucker's PR #1538): |
Did you guys decide to punt on making all the task headers blue w/ grey-text as sub-headers? Sorry I made the instructions confusing by referencing what was really an H2 as an H1, and I later noticed I'd also spec'd the incorrect blue. Other than those (dorky) nits, I'm super stoked to see how implementing the other recommendations are coming along—yeah!!! :) |
No worries - and yep @heartsucker implemented the left aligning and blue coloring of headers in #1538 (so those changes won't appear in this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this correctly implements everything Jen listed in #1536 (comment). The journalist interface is in a broken state, but #1538 fixes it, so letting that be and merging.
Makes two updates to the text of the Source Interface in order to match the new screenshots: Renames Source Interface button "Logout" -> "Exit" in docs The name of the "logout" button as presented in the Source Interface changed back in #1534, but the corresponding documentation was never updated. Now that the screenshots show the new "Exit" button, we must also update the guiding language to refer explicitly to an "Exit" button, not a "Logout" button. Updates Source codename displayed in-line to match the screenshots. Since Source codenames are randomly generated, updating the screenshots means we'll definitely get a new codename, so let's update the in-line text to match what's displayed in the visual aids, to avoid confusion.
These are a couple of small changes to the source interface suggested by @ninavizz in her UX feedback and mockup of the source interface shown here.
Adds a "Cancel" button (from UX feedback: "Giving users a cancel option reduces anxiety"):
Displays which journalist is speaking to the source on the source interface (when you're on the source side, it's a little confusing to know who you are talking to in the news org - is it the point person/admin, journalist Bob, journalist Alice??):
Also after #1523 is merged we could indeed display the full name and blurb as displayed in her mockup - happy to make that change when the time comes