Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source interface UX improvements #1534

Merged
merged 4 commits into from
Feb 2, 2017
Merged

Conversation

redshiftzero
Copy link
Contributor

These are a couple of small changes to the source interface suggested by @ninavizz in her UX feedback and mockup of the source interface shown here.

Adds a "Cancel" button (from UX feedback: "Giving users a cancel option reduces anxiety"):

explicit-cancel-button

Displays which journalist is speaking to the source on the source interface (when you're on the source side, it's a little confusing to know who you are talking to in the news org - is it the point person/admin, journalist Bob, journalist Alice??):

which-journo

Also after #1523 is merged we could indeed display the full name and blurb as displayed in her mockup - happy to make that change when the time comes

@ninavizz
Copy link
Member

Could the "Cancel" button be next to the Submit button—not below it—and white background with dark text? All the submitted mockups reflect existing interaction paradigms users expect. Stacking the buttons is very odd and will be confusing.
screenshot_cancel-butt

@redshiftzero
Copy link
Contributor Author

Thanks for this feedback @ninavizz! I'll modify this PR to make this change.

@ninavizz
Copy link
Member

ninavizz commented Jan 27, 2017

No biggie—I'm creating a single new "issue" for all my 0.4 reccos, with each tweak numbered—so that you and @fowlslegs can more easily reference stuff in PRs. (and yes, am clearly labeling it as a reference-only document, that you and noah need to cite items on for them to be included into any builds) :)

@redshiftzero
Copy link
Contributor Author

Great - thanks for doing that @ninavizz!

@psivesely
Copy link
Contributor

I was going to make the same comment on the button location and color scheme, but @ninavizz beat me to it 😸 It's such a simple PR, but it would still be nice to add a functional test that clicks it during a upload and makes sure it does it's job to prevent against future regressions.

@redshiftzero redshiftzero force-pushed the ux-source-interface-round-1 branch 2 times, most recently from e94c66a to c95e9e6 Compare February 1, 2017 19:56
@redshiftzero redshiftzero force-pushed the ux-source-interface-round-1 branch from c95e9e6 to 5f3b559 Compare February 1, 2017 20:19
@redshiftzero
Copy link
Contributor Author

I've modified this PR following the detailed guidance provided in #1536 and implemented a few more of the items from there:

  • Item 9b: Change h1 text to "Submit Materials" and "Get Replies"
  • Item 9d: Move GPG text to below the header, format it gray and left-aligned
  • Item 9e: Change graphic from cloud to the data store icon made by @ninavizz
  • Item 9f: Adds Cancel button next to the Submit button
  • Item 9i: Change “Log Out” to “Exit”
  • Item 10a: Modify login text to "Enter codename"
  • Item 10b: Add a "Cancel" button here too

Also added functional tests for the new "Cancel" buttons on /login and /lookup

Screenshots of the login and submit pages (note that the formatting of the button text as caps and the headlines is covered by @heartsucker's PR #1538):

login

submit

@redshiftzero redshiftzero changed the title Source interface UX improvements: Add explicit cancel button and From field in replies Source interface UX improvements Feb 1, 2017
@ninavizz
Copy link
Member

ninavizz commented Feb 1, 2017

Did you guys decide to punt on making all the task headers blue w/ grey-text as sub-headers? Sorry I made the instructions confusing by referencing what was really an H2 as an H1, and I later noticed I'd also spec'd the incorrect blue. #7a84a4 is the correct wedgewood blue for the headers, and #555 would work for the description text.

Other than those (dorky) nits, I'm super stoked to see how implementing the other recommendations are coming along—yeah!!! :)

@redshiftzero
Copy link
Contributor Author

No worries - and yep @heartsucker implemented the left aligning and blue coloring of headers in #1538 (so those changes won't appear in this PR)

Copy link
Contributor

@psivesely psivesely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this correctly implements everything Jen listed in #1536 (comment). The journalist interface is in a broken state, but #1538 fixes it, so letting that be and merging.

@psivesely psivesely merged commit 37f1e90 into develop Feb 2, 2017
@redshiftzero redshiftzero deleted the ux-source-interface-round-1 branch February 2, 2017 15:20
redshiftzero added a commit that referenced this pull request Apr 21, 2017
In 413e887 in #1534 we added the
display of journalist usernames in replies shown to sources in order
to improve source UX. However, we have decided that this is a change we
want to push until post-0.4, so we are going to change this back for now..
redshiftzero added a commit that referenced this pull request Apr 21, 2017
In 413e887 in #1534 we added the
display of journalist usernames in replies shown to sources in order
to improve source UX. However, we have decided that this is a change we
want to push until post-0.4, so we are going to change this back for now..
conorsch pushed a commit that referenced this pull request Jul 20, 2017
Makes two updates to the text of the Source Interface in order to match
the new screenshots:

Renames Source Interface button "Logout" -> "Exit" in docs

The name of the "logout" button as presented in the Source Interface
changed back in #1534, but the corresponding documentation was never
updated. Now that the screenshots show the new "Exit" button, we must
also update the guiding language to refer explicitly to an "Exit"
button, not a "Logout" button.

Updates Source codename displayed in-line to match the screenshots.
Since Source codenames are randomly generated, updating the screenshots
means we'll definitely get a new codename, so let's update the in-line
text to match what's displayed in the visual aids, to avoid confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants