Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Firewall doc needs correcting #1025

Closed
harlo opened this issue May 13, 2015 · 5 comments
Closed

Network Firewall doc needs correcting #1025

harlo opened this issue May 13, 2015 · 5 comments
Assignees
@harlo
Labels
docs

Comments

@harlo
Copy link
Contributor

harlo commented May 13, 2015

References to "Connection Information" should be replaced with "Edit Connections...". Replace corresponding screencap, too.

See:

https://github.com/freedomofpress/securedrop/blob/0.3.3/docs/network_firewall.md#disable-dhcp-on-the-lan
@harlo
Copy link
Contributor Author

harlo commented May 14, 2015

Another thing: clarify CIDR allocation for OPT1 and LAN (24)
Because pfsense will "guess" for you, sometimes it guesses 32, which is wrong.

@harlo harlo self-assigned this May 15, 2015
@harlo harlo added the docs label May 15, 2015
@dolanjs dolanjs added this to the 0.3.4 milestone Jun 9, 2015
harlo pushed a commit to harlo/securedrop that referenced this issue Jun 23, 2015
CIDR prefix tips for network firewall doc (as per freedomofpress#1025)
f73172d
harlo pushed a commit to harlo/securedrop that referenced this issue Jun 23, 2015
CIDR prefix tips for network firewall doc (as per freedomofpress#1025)
90fabc4
harlo pushed a commit to harlo/securedrop that referenced this issue Jun 23, 2015
CIDR prefix tips for network firewall doc (as per freedomofpress#1025)
3994baa
harlo pushed a commit to harlo/securedrop that referenced this issue Jun 23, 2015
CIDR prefix tips for network firewall doc (as per freedomofpress#1025)
4df95a1
harlo pushed a commit to harlo/securedrop that referenced this issue Jun 23, 2015
CIDR prefix tips for network firewall doc (as per freedomofpress#1025)
40eaa26
@harlo harlo mentioned this issue Jun 23, 2015
Merged
@conorsch
Copy link
Contributor

Reformatting for clarity:

Things to change

@harlo
Copy link
Contributor Author

harlo commented Jun 24, 2015

Turns out, only item #3 (the CIDR mapping bit) is relevant. Items 1 + 2 are fine the way they are.

@conorsch conorsch mentioned this issue Jun 25, 2015
Merged
harlo pushed a commit that referenced this issue Jun 26, 2015
Merge pull request #1060 from harlo/1025_network_firewall
44adebb 
Network Firewall docs (issue #1025)
@garrettr
Copy link
Contributor

This was merged for release/0.3.4 in #1060. Taking this off of the 0.3.4 milestone as using #1060 as the marker there instead, since this will also need to be resolved for the develop branch.

@garrettr garrettr removed this from the 0.3.4 milestone Jun 26, 2015
@garrettr
Copy link
Contributor

These changes were merged into develop in #1075.

ghost pushed a commit to DC4EC4F68F5C9F5B/securedrop-docs that referenced this issue Dec 18, 2015
CIDR prefix tips for network firewall doc (as per freedomofpress/secu…
d50dde5 
…redrop#1025)
kushaldas added a commit that referenced this issue Apr 22, 2020
@kushaldas
Partical fix for #1025 Faster sync for all source
86565e5 
Implements only get_sources call
@kushaldas kushaldas mentioned this issue Apr 22, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harlo harlo

Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@harlo @garrettr @conorsch @dolanjs