Safely shut down sys-usb; tweak logging #532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Resolves #531. Makes logging slightly more verbose to help diagnose issues with specific VMs.
sys-whonix
is now treated as a "safe to shut down" system VM along withsys-usb
(sd-whonix
does not depend on it running).Testing
Preparatory steps
(All testing should be done with an existing Qubes install at least at
0.2.4-rpm
- dev, prod or staging should make no difference)/opt/securedrop/launcher
and/srv/salt/launcher
(if only the/opt
copy is overwritten, the updater itself will replace it on the next run).zlib
(dnf downgrade zlib
) infedora-30
to ensure a realistic update scenario. Power offfedora-30
.Scenario: fedora-30 update
/opt/securedrop/launcher/sdw-launcher.py --skip-delta 0
. This forces an updater run.zlib
package infedora-30
is now at the latest version~/.securedrop_launcher/logs/launcher.log
sys-usb
is running as expected and that thesd-devices
workflow (automatic attachment of a LUKS-encrypted USB block device or USB printer tosd-devices
) still works.You may still encounter #498 due to the continued use of
qvm-kill
.Checklist
make flake8
) passes in the development environment (this box maybe left unchecked, as
flake8
also runs in CI)make test
) pass indom0
of a Qubes install (N/A, updater has its own test suite which passes)