Fixes vmname via rc.local

[kushaldas]

Status

Work in progress

Description of Changes

All VMs and templates has separate vmname for securedrop-log
via rsyslog.

Fixes #476 (partially) till now.

Testing

• make all
• Check sd-log vm for separate logs for the app vms and template vms.
• make test shows no errors

Checklist

If you have made code changes

• Linter (make flake8) passes in the development environment (this box may
  be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

• All tests (make test) pass in dom0 of a Qubes install

• This PR adds/removes files, and includes required updates to the packaging
  logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

[kushaldas]

While doing a make all for this PR/branch, I am getting an error with Tor in sd-whonix.

DisableNetwork 1 it can not restart saying that line is mentioned at the end somewhere. Can anyone please have a look?

[conorsch]

Rather than add salt logic to customize the VM name, let's instead just trust the hostname returned by the VM (regardless of whether AppVM or TemplateVM), and use that. Doing so will require a small update to the logging package, but remove the need to treat each VM differently. See related discussion in #476 (comment)

[conorsch]

Took a stab at simplifying the securedrop-log config logic, there's a WIP in a separate branch: https://github.com/freedomofpress/securedrop-workstation/compare/476-simplify-logging-hostname-config Not opening a PR because I haven't tested it fully yet, will revisit soon.

[conorsch]

See #487 for an alternative implementation. If merged, #487 would supersede (and therefore close) this PR.

[kushaldas]

Closing as we chose #487 over this one.