Provision submission key fingerprint in config.json to sd-svs #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SecureDrop client expects a file named config.json in /home/user/.securedrop_client/ containing the journalist key fingerprint. This key is used to encrypt replies to the submission (journalist key), so that replies can be decrypted by journalists in the client. This is because replies are encrypted in the client. /home/user/.securedrop_client folder is populated on first run, and since it's the home directory, must be applied to `sd-svs` and not `sd-svs-template` dom0 config.json file should now contain the GPG fingerprint of the submission key, which will populate config.json file in sd-svs.
emkll
force-pushed
the
475-client-reply-fix
branch
from
6ce3ac3 to
8fff04c
Compare
There was a problem hiding this comment.
i ran make test and see a couple issues (the first one ive seen before):
- policy issue
Policy for VMShell should be:
### BEGIN securedrop-workstation ###
$anyvm $tag:sd-workstation deny
### END securedrop-workstation ###
FAIL
- submission_key_fpr error
ERROR: test_sd_client_config (test_svs.SD_SVS_Tests)
...
KeyError: 'submssion_key_fpr'
...
FAIL: test_Policies (test_qubes_rpc.SD_Qubes_Rpc_Tests)
|
oh i see the new |
sssoleileraaa
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
works beautifully with the securedrop client debian package. will just need a follow-up securedrop-client issue to get this working when running the client via the run.sh script, which will default to a tmp directory. we will need to copy the config.json file there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards freedomofpress/securedrop-client#475
The SecureDrop client expects a file named config.json in /home/user/.securedrop_client/ containing the journalist key fingerprint. This key is used to encrypt replies to the submission (journalist key), so that replies can be decrypted by journalists in the client. This is because replies are encrypted in the client.
/home/user/.securedrop_client folder is populated on first run, and since it's the home directory, must be applied to
sd-svsand notsd-svs-templatedom0 config.json file should now contain the GPG fingerprint of the submission key, which will populate config.json file in sd-svs.
Test plan
make cleanmake clonesubmission_key_fprcontaining the GPG fingerprint of the SecureDrop instance usedmake allmake test