-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install docs #21
Add install docs #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass visual review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - few changes as a result of our walkthrough
a08b855
to
02d1030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs look great @zenmonkeykstop , left a few comments inline
docs/admin/install.rst
Outdated
|
||
securedrop-admin --uninstall | ||
|
||
This will remove all associated VMs and configuration details, and uninstall the ``dom0`` SecureDrop Workstation package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is freedomofpress/securedrop-workstation#505 worth noting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO if we expect that warnings will be shown then we should note it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug that we should fix. We should not expect users to interpret error messages to figure out if they're "okay" ones.
Regarding the recommendation for the default user password:
With these tradeoffs in mind, I think we should use language like this:
Qubes itself provides a strength indicator while you set the password, so I think this is sufficient guidance. Thoughts? |
Provided the finding/changes in freedomofpress/securedrop-workstation#510 are valid, we should make an update to these docs as well. |
18f309c
to
385c1f5
Compare
Added some notes to BIOS section; thanks a lot for putting this together and for your patience w/ review, these docs are really looking great already. |
385c1f5
to
3cf36fb
Compare
Couple small comments re: the BIOS docs, and would still recommend copy/paste instructions for the steps performed in the |
a139967
to
23ee186
Compare
Thanks, pushed a rebased version to keep the commit count down :) |
Looks great, doing a quick final visual review before merging. :) |
1004095
to
58b38b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all your hard work on this.
Adds installation docs page in Admin section.