This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
parse filename when posting reply #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
force-pushed
the
reply-filename
branch
from
c0f4b65 to
72476f5
Compare
heartsucker
requested review from
kushaldas and
redshiftzero
and removed request for
kushaldas
|
Hey @kushaldas - want to review this one? (good to get into the next SDK release for the replies functionality) |
kushaldas
approved these changes
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to support freedomofpress/securedrop#4047
Note: Semver allows making breaking changes when the leading non-zero number is incremented, and we have the breaking change that this will not work on securedrops that do not have the patch from freedomofpress/securedrop#4047 applied. We could change the code and add a test to support both cases if we feel that we need to have high concern for backwards compatibility this early in the lifetime of the project.