This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
ci: fail build if build requirements need update #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup from: #37
This is the same PR as in freedomofpress/securedrop-client#436 just now for the proxy
mastermust always produce a packaged proxy that is in a working state after build: in #37 we verified that the build succeeds onmaster. However: ifbuild-requirements.txtis out of sync withrequirements.txt, the proxy may not work as expected if it relies on functionality added in the new dependency added inrequirements.txt.This PR runs
make requirementsprior to build such that the build will fail ifbuild-requirements.txtis out of sync withrequirements.txt