Rename update script #4

emkll · 2019-07-25T13:32:52Z

Closes #3
Other repos use update_version.sh:

https://github.com/freedomofpress/securedrop-client/
https://github.com/freedomofpress/securedrop-proxy/

Other repos use update_version.sh: https://github.com/freedomofpress/securedrop-client/ https://github.com/freedomofpress/securedrop-proxy/

2.4.1 was no longer available on pypi: https://circleci.com/gh/freedomofpress/securedrop-export/27

kushaldas

Looks good. Approved.

zenmonkeykstop · 2019-07-25T14:04:51Z

pip install --require-hashes -r test-requirements.txt completes without error and installs pyparsing.
renamed update script is good.

emkll added 2 commits July 25, 2019 09:24

Rename update-version.sh for consistency.

eba6ec1

Other repos use update_version.sh: https://github.com/freedomofpress/securedrop-client/ https://github.com/freedomofpress/securedrop-proxy/

Update pyparsing to 2.4.1.1

73c3d77

2.4.1 was no longer available on pypi: https://circleci.com/gh/freedomofpress/securedrop-export/27

emkll requested review from kushaldas and zenmonkeykstop July 25, 2019 13:32

kushaldas approved these changes Jul 25, 2019

View reviewed changes

kushaldas merged commit 5747419 into master Jul 25, 2019

kushaldas deleted the rename-update-script branch July 25, 2019 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename update script #4

Rename update script #4

emkll commented Jul 25, 2019

kushaldas left a comment

zenmonkeykstop commented Jul 25, 2019 •

edited

Loading

Rename update script #4

Rename update script #4

Conversation

emkll commented Jul 25, 2019

kushaldas left a comment

Choose a reason for hiding this comment

zenmonkeykstop commented Jul 25, 2019 • edited Loading

zenmonkeykstop commented Jul 25, 2019 •

edited

Loading