Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server installation instructions to use Focal instead of Xenial #154

Merged
merged 4 commits into from
Mar 8, 2021

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

  • Updates server OS install instructions to use Ubuntu 20.04 LTS
  • Removes workarounds for NUC8 Ethernet support, as they're not required with Focal's base kernel.

Testing

  • Are the docs clear and correct?
  • Following them, do you get a valid SD install?

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed not tested
  • You have previewed (make docs) docs at http://localhost:8000

@rocodes rocodes self-requested a review February 17, 2021 17:51
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM--some comments in the FDE section (can take em or leave em), some nits, but I stepped through these last night and they are clear and easy to follow.

docs/servers.rst Outdated Show resolved Hide resolved
docs/servers.rst Outdated Show resolved Hide resolved
docs/servers.rst Show resolved Hide resolved
docs/servers.rst Show resolved Hide resolved
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny typo, otherwise looking good.

Additional note: as per support comms, could be advisable to include a note about disabling SecureBoot in BIOS (and ensuring BIOS is up to date on the servers). We can take inspiration from the Workstation docs:

https://github.com/freedomofpress/securedrop-workstation-docs/blob/main/docs/admin/install.rst#apply-bios-updates-and-check-settings

docs/servers.rst Outdated Show resolved Hide resolved
@zenmonkeykstop
Copy link
Contributor Author

Agreed on the SecureBoot thing - tho it could probably live with wherever in the docs we talk about BIOS configuration. I know you added something for that recently? Maybe let's just link that up here.

gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 8439 38DF 228D 22F7 B374 2BC0 D94A A3F0 EFE2 1092

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preceding paragraph states that "Good signature" is expected twice in the output, but this is no longer the case; it only occurs once.

@@ -141,7 +150,7 @@ Ubuntu installer.
If your USB is mapped to /dev/sdX and you are currently in the directory that
contains the Ubuntu ISO, you would use dd like so: ::

sudo dd conv=fdatasync if=ubuntu-16.04.7-server-amd64.iso of=/dev/sdX
sudo dd conv=fdatasync if=ubuntu-20.04.2-live-server-amd64.iso of=/dev/sdX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth explicitly emphasizing that one must specify the device, not a partition like /dev/sdb1. Yes, I'm saying this because I was just bitten by it. :)

@eloquence
Copy link
Member

eloquence commented Feb 20, 2021

I stepped through the OS portion of the installation (on a NUC10) and the updated instructions worked well, i.e., the dialogs presented during installation matched the updated documentation in this PR, and resulted in a bootable Ubuntu 20.04 system with connectivity behind firewall. :)

This was referenced Feb 26, 2021
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. There were a couple of small changes requested by @eloquence (The note about "Good Signature" being once, not twice, and the note about /dev/sdb vs /dev/sdb1 for installation media.)

@rocodes
Copy link
Contributor

rocodes commented Mar 8, 2021

@zenmonkeykstop looks like there are conflicts here, otherwise I'll approve and merge.

Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per conversation with @zenmonkeykstop and @eloquence , fixed merge conflict (fixed in 74a4d24), approving and merging.

@rocodes rocodes merged commit 2b8e5da into main Mar 8, 2021
@legoktm legoktm deleted the fosse-install branch May 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants