-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause queue on auth errors, connection failures and timeouts #531
Conversation
1bf6083
to
aec3999
Compare
aec3999
to
dbb2359
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work! 😍 based on visual review of the diff lgtm (i.e. i haven't run through the test plan yet in qubes), just one minor comment inline, otherwise all my comments from #514 (comment) have been addressed
(btw also needs rebase on top of latest)
dbb2359
to
ee2ec5e
Compare
Notes for the reviewer of this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all my comments were addressed, thanks!
Description
The queues now pause when there is either an auth error, api connection failure, or request timeout error. The queues resume when the user clicks "Retry" or upon a sync/refresh after the issues are resolved.
Resolves #443
Towards #391
Test Plan
Make sure acceptance criteria is satisfied: #391 (comment), and follow these steps:
RequestTimeoutError with Retry link
ApiInaccessibleError
ApiInaccessibleError
and see the reply bar turn red in the gui and the SecureDrop error message without the Retry link.Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable: