fix(securedrop-whonix-config): depend on anon-gw-anonymizer-config
#2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we're at it, clarify why as a one-shot operation this service has explicit "After"- as well as "Requires"-dependencies.
cfm
force-pushed
the
sdw-1051-service-order
branch
from
7650893 to
67ee290
Compare
3 tasks
legoktm
approved these changes
Jun 5, 2024
| @@ -49,6 +49,7 @@ Description: Tools for configuring non-Qubes-aware applications from QubesDB. | |||
| Package: securedrop-whonix-config | |||
| Section: admin | |||
| Architecture: all | |||
| # FIXME: s/tor/anon-gw-anonymizer-config/ (requires Whonix repositories in piuparts) | |||
There was a problem hiding this comment.
The repository list never ends... 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Fixes freedomofpress/securedrop-workstation#1051 (review).
Test Plan
securedrop-whonix-config.whonix-gateway-17.sd-whonix,systemctl securedrop-whonix-configshows a successful execution.Or follow the test plan in freedomofpress/securedrop-workstation#1051 (comment).
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable: