Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source widget ui polish #1191

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Source widget ui polish #1191

merged 1 commit into from
Dec 4, 2020

Conversation

sssoleileraaa
Copy link
Contributor

Description

Resolves #1174

Test Plan

  1. Log into the client select sources and see source name turn blue when selected
  2. Log out and verify the same behavior ^
  3. Compare layout to https://scene.zeplin.io/project/5c807ea562f734bd2756b243/screen/5f35fbb85de1037e11c88dab or the image in Source list UI facelift #1174 (make sure it's zoomed out to 100% to match the client size)

@sssoleileraaa sssoleileraaa changed the base branch from main to seen November 19, 2020 17:08
@sssoleileraaa sssoleileraaa force-pushed the source-widget-ui-polish branch from 0c18dad to 26fa3a9 Compare November 19, 2020 23:17
@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Nov 19, 2020

Also included in this PR:

  • update to conversation view bg color
  • top-right shadowing for message bubbles, top-left shadowing for reply bubbles
  • changed download file message color (see "Encrypted file on server")
  • source list hover color now slightly lighter than the new selected color
  • disabled replybox (offline-mode relybox) now has a background color of white

@sssoleileraaa sssoleileraaa force-pushed the source-widget-ui-polish branch 4 times, most recently from 8dca1bf to c0c2fcf Compare November 20, 2020 00:26
Base automatically changed from seen to main November 25, 2020 21:26
@sssoleileraaa sssoleileraaa force-pushed the source-widget-ui-polish branch from c0c2fcf to be87c99 Compare November 25, 2020 22:51
@sssoleileraaa
Copy link
Contributor Author

I just pushed some changes so it'll be easy to check out both ways of arranging dates and attachments for our demo and UI discussion on Thursday. We'll want to choose one and rebase.

@sssoleileraaa sssoleileraaa force-pushed the source-widget-ui-polish branch from c880fe2 to 3c3aa2c Compare December 3, 2020 20:05
@sssoleileraaa sssoleileraaa force-pushed the source-widget-ui-polish branch from 3c3aa2c to 0374bf2 Compare December 3, 2020 20:13
@emkll
Copy link
Contributor

emkll commented Dec 4, 2020

Thanks @creviera spacing looks great with these changes, we can see much more sources in the source widget.

I tested this PR in Qubes after building the package, and observed an issue after first sync with the source widget: the colors of the sources and the message preview is blue (see below). This looks very simiar to what i've encountered in #1165, perhaps an issue with css changes?

blue-sources

@emkll emkll self-assigned this Dec 4, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to pull latest changes, was reviewing c0c2fcf instead of 0374bf2 (sorry! In retrospect, we now know the root cause, see #1165 ) . I can confirm that with the latest revision, the changes here work well (and look great) in Qubes . To my eye, the changes here match the designs linked in the description. Let's merge these changes to get them into nightlies and address any other improvements separately.

Thanks @creviera for the changes and for the debugging assistance

@emkll emkll merged commit 0e8e570 into main Dec 4, 2020
@emkll emkll deleted the source-widget-ui-polish branch December 4, 2020 22:49
@sssoleileraaa sssoleileraaa mentioned this pull request Dec 8, 2020
14 tasks
@eloquence eloquence mentioned this pull request Dec 8, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source list UI facelift
2 participants