-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source widget ui polish #1191
Source widget ui polish #1191
Conversation
0c18dad
to
26fa3a9
Compare
Also included in this PR:
|
8dca1bf
to
c0c2fcf
Compare
c0c2fcf
to
be87c99
Compare
I just pushed some changes so it'll be easy to check out both ways of arranging dates and attachments for our demo and UI discussion on Thursday. We'll want to choose one and rebase. |
c880fe2
to
3c3aa2c
Compare
3c3aa2c
to
0374bf2
Compare
Thanks @creviera spacing looks great with these changes, we can see much more sources in the source widget. I tested this PR in Qubes after building the package, and observed an issue after first sync with the source widget: the colors of the sources and the message preview is blue (see below). This looks very simiar to what i've encountered in #1165, perhaps an issue with css changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to pull latest changes, was reviewing c0c2fcf instead of 0374bf2 (sorry! In retrospect, we now know the root cause, see #1165 ) . I can confirm that with the latest revision, the changes here work well (and look great) in Qubes . To my eye, the changes here match the designs linked in the description. Let's merge these changes to get them into nightlies and address any other improvements separately.
Thanks @creviera for the changes and for the debugging assistance
Description
Resolves #1174
Test Plan