Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds copy on message bubble click.
Resolves #1052
Does not fix #815
After testing with some of the strings provided by https://github.com/minimaxir/big-list-of-naughty-strings/blob/master/blns.txt (thanks @redshiftzero for the link) I see that #1050 won't be ready for a while (just try with one of our test data strings, e.g. https://github.com/freedomofpress/securedrop-client/wiki/Message-Test-Data#105127-character-image-url), so I created this spike to implement message-copy by clicking on speech bubbles. This isn't a full-fledged feature. There is no current hover or active state when you click on a speech bubble, so there is no indicator that the text was copied to the clipboard.
I could add a popup that says "Copied!" or something, but I wanted to open up this PR so people like @eloquence could take a look and provide feedback about using this as an interim solution while we continue to investigate issues found in #1050.
Test Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable: