Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview most recent message or reply in source view #135

Closed
eloquence opened this issue Nov 9, 2018 · 7 comments · Fixed by #698
Closed

Preview most recent message or reply in source view #135

eloquence opened this issue Nov 9, 2018 · 7 comments · Fixed by #698

Comments

@eloquence
Copy link
Member

eloquence commented Nov 9, 2018

Below the source designation, the source list should show a preview (text abbreviated with "..." if necessary) of the most recent message or reply, as shown in this grayscale wireframe:

snippets

If the most recent interaction is a message from the source, it should show an excerpt of that message; if the most recent interaction is a reply from the journalist, it should an excerpt of the reply.

If the most recent interaction is a file upload, we should show the most recent message or reply.

If there has never been any message or reply but only a file, we can show "—submitted a file, no message—".

@eloquence eloquence added help wanted Extra attention is needed stretch goal labels Nov 9, 2018
@eloquence eloquence added this to the 0.1.0alpha milestone Nov 9, 2018
@eloquence
Copy link
Member Author

eloquence commented Nov 9, 2018

For anyone wanting to work on this issue, the code removed in abdbf41 may give some useful pointers how to update the source list.

@timruffles
Copy link
Contributor

Will take a look.

@sssoleileraaa
Copy link
Contributor

Note: Once we add the preview snippets, the width available for preview snippets should scale up or down if you resize the client window, but the space to the left and to the right in the source list should not scale up along with it, but be fixed.

@ninavizz
Copy link
Member

ninavizz commented May 1, 2019

Commenting to update preview message text from: — submitted a file, no message —
...to: — file only — (pls mind the spaces between the em-dashes and the characters before and after)

I don't know if there'd be a lot of logic involved in pluralizing, but per the rough rule for grouping files in the File Pane (if a Source submits more than 1 document in a 12 hour period, it is visually shown as a group—vs as individual stand-alone files) it'd also be great to have the pluralized message display if more than 1 document is received in a 12 hour period: — files only —

bump, @creviera :)

Also, per the OG comment: This should only display if the Source has never sent a message, and/or the Newsroom has never sent a response. If a Source sends just a message, in a thread, then the most recent message should go in the preview.

@ntoll
Copy link
Contributor

ntoll commented Jan 13, 2020

FYI, I started work on this this afternoon. Please move to "in development". Thanks.

@ntoll
Copy link
Contributor

ntoll commented Jan 14, 2020

OK... here's a screenie of the working solution. I need to clean up the code a little but PR imminent. :-)
latest_message_preview

@ntoll
Copy link
Contributor

ntoll commented Jan 14, 2020

The "reply not yet available" message will disappear upon each refresh (it's just on first start the messages have not been made available yet).

ntoll added a commit to ntoll/securedrop-client that referenced this issue Jan 14, 2020
sssoleileraaa pushed a commit that referenced this issue Jan 16, 2020
sssoleileraaa pushed a commit that referenced this issue Jan 17, 2020
legoktm pushed a commit that referenced this issue Dec 15, 2023
Fix TOTP retry logic, improve cassette handling; document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment