-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform independent file opening #115
Comments
This is very nice to have for development but not absolutely critical for beta since we must test everything in Qubes anyway, so added to Post-Beta milestone for now. |
From 2022-08-22 review with @nathandyer @cfm @gonzalo-bulnes @eloquence: |
Loosely related to #1541, which should make swapping QVM for something else easier. |
Ensure correct OS version builds requirements file
Replace werkzeug dependency with basic string checks
We use
QProcess
to open files in a disposable VM usingqvm-open-in-vm
, which is a Qubes-only program. We could usexdg-open
to open files such that this file open process would also work in Linux, but by always usingqvm-open-in-vm
, we get defense in depth as we will not accidentally open a file in thesd-app
AppVM if there is a misconfiguration with the mime type handlers in the sd-app VM.The problem with this is that now on Mac or Linux, we can't open files. We can apply a patch, like:
for testing, but this is not convenient for developers. Another approach is in the above diff, to subprocess out to a script that calls
open
(macOS) orxdg-open
, depending on what the current platform is. This ticket is for implementing that approach (or a better idea if you have one!).(Followup to #113)
The text was updated successfully, but these errors were encountered: