Test PR DO NOT MERGE #214
Closed
Test PR DO NOT MERGE #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch stops accessing the webbased index for the wheels, instead uses the local filesystem path.
Adjusting the error-handling based on a recent signing operation. Makes the tooling a bit friendlier for maintainers.
In order to regenerate the wheel files, I ran: ./scripts/build-sync-wheels --clobber -p ../securedrop-client ./scripts/build-sync-wheels --clobber -p ../securedrop-log ./scripts/build-sync-wheels --clobber -p ../securedrop-proxy Each repo had the latest "main" branch commit checked out. Then I ran ./scripts/sync-sha256sums, completed the signing ceremony, and committed the results.
Uses the feature branches for the component repos, to aid in review.
Tries to build nightly as the wheel sha256sums are different now from the last release.
kushaldas
force-pushed
the
test_pr_dont_merge
branch
6 times, most recently
from
95844fb to
d2ee718
Compare
kushaldas
force-pushed
the
test_pr_dont_merge
branch
from
d2ee718 to
a6a2879
Compare
|
Oh my, magic!!! |
9 tasks
added 3 commits
January 15, 2021 14:38
More pytest-based reprotest invocations, this time focusing on .deb files. Replaces the CircleCI repro tests that manually compared hashes. Also modifies build script to support commit hash The logic assumed we were always building from a prod release tag. As a result, the CI logic was reimplementing the tarball mangling. Let's make the script more flexible, so we can run the script in CI and thereby get a bit more test coverage for it.
Required only to get CI passing, should be dropped before merge.
conorsch
force-pushed
the
test_pr_dont_merge
branch
from
5640457 to
7686880
Compare
|
Nice work, I'm going to continue the discussion in #213, and have already pulled this work into that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.