Fixes #141 removes upstream virtualenv from image #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the upstream circleci Python image is coming with the latest virtualenv, which is causing our builds to fail. This PR removes the installation done via pip. It also has YAML formatting fix for another job, and a comment set. Done via YAML linter/formatter.
redshiftzero
approved these changes
Feb 11, 2020
|
@kushaldas want to make PRs into the other workstation subcomponent repos with build jobs adding this run step? |
kushaldas
added a commit
to freedomofpress/securedrop-client
that referenced
this pull request
Feb 11, 2020
freedomofpress/securedrop-builder#142 ^^ related to above PR.
6 tasks
kushaldas
added a commit
to freedomofpress/securedrop-export
that referenced
this pull request
Feb 11, 2020
freedomofpress/securedrop-builder#142 ^^ related to above PR.
kushaldas
added a commit
to freedomofpress/securedrop-proxy
that referenced
this pull request
Feb 11, 2020
freedomofpress/securedrop-builder#142 ^^ related to above PR.
kushaldas
added a commit
to freedomofpress/securedrop-log
that referenced
this pull request
Feb 11, 2020
freedomofpress/securedrop-builder#142 ^^ related to above PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the upstream circleci Python image is coming with the latest
virtualenv, which is causing our builds to fail. This PR removes
the installation done via pip.
It also has YAML formatting fix for another job, and a comment set.
Done via YAML linter/formatter.
How to test?
All Debian package builds in CI should be green.
After this PR is merged, any open PR on this repo should be rebased.