Minor changes

[almet]

A small pull request with changes I did while reading the current codebase.

I've added some comments directly on Github when it made sense.

[almet]

I converted this PR to a draft for now, until I have the tests running properly on my machine, so I can replicate what the CI is telling me :-)

[almet]

I've put the changes for pytest fixtures in a separate PR: #813

[almet]

Current linting failures are due to a bug on mypy, which will mark code as unreachable if behind a boolean assert, like this:

assert something is True
assert somethingelse # <-- this is considered unreachable

I'm considering removing the --warn-unreachable flag for the tests.

[almet]

Tests are failing due the latest Alpine image. This should be fixed with #812.

@apyrgio I'm curious about your feedback on disabling the mypy --warn-unreachable flag for the tests. Maybe there is a better way :-)

[apyrgio]

@apyrgio I'm curious about your feedback on disabling the mypy --warn-unreachable flag for the tests. Maybe there is a better way :-)

I'd be more inclined to use # type: ignore [unreachable] in affected lines, since there may be an actual case where something is unreachable in our tests, and we want t the linter to flag it.

[almet]

I'd be more inclined to use # type: ignore [unreachable] in affected lines, since there may be an actual case where something is unreachable in our tests, and we want t the linter to flag it.

That's indeed a better solution :-) I've updated the branch accordingly, and force-pushed.

[apyrgio]

Thanks for the changes, they look good to me. I think once you rebase this PR on top of the main branch, and all the tests pass, you can merge it.

[almet]

Just rebased this branch on top of latest main