Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install patched conmon from our apt-tools-prod repo #708

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Feb 13, 2024

The oldstable-proposed-updates Debian repo no longer offers a patched conmon version, since this has now been integrated in Debian Bullseye (see https://tracker.debian.org/pkg/conmon). Since we want to test as close to the end-user environment as possible, change our CI code to install conmon from the apt-tools-prod repo.

Refs #685

Now that the conmon package with version 2.0.25+ds1-1.1+deb11u1 has been
released [1] for Debian Bullseye, there is no need to install it from
the oldstable-proposed-updates repo any more.

[1]: https://tracker.debian.org/pkg/conmon
Instead of installing a patched conmon version from the
oldstable-proposed-updates repo, install it from our apt-tools-prod
repo. This applies to just Ubuntu Jammy, since the rest of the platforms
don't have this problem.
Copy link
Contributor

@deeplow deeplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI is not complete yet, but the Jammy-related runners seem to have worked. Thanks!

Update the build instructions for Ubuntu Jammy regarding conmon, now
that oldstable-proposed-updates no longer offers a patched conmon
package. Propose instead to install conmon from our apt-tools-prod repo.
@apyrgio
Copy link
Contributor Author

apyrgio commented Feb 13, 2024

Everything passed, except for the security scans. However, I just realized that our build instructions are not up-to-date with the new change. I pushed a commit to fix them (2703448).

@deeplow
Copy link
Contributor

deeplow commented Feb 13, 2024

Good catch. Feel free to merge.

@apyrgio apyrgio merged commit 2703448 into main Feb 13, 2024
48 of 50 checks passed
@apyrgio apyrgio deleted the 2023-02-conmon-backport branch February 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants