Reinstate support for Ubuntu Focal #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apyrgio
force-pushed
the
206-support-ubuntu-focal
branch
from
4e11a45 to
ab51579
Compare
deeplow
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Some other stuff that needs to be done:
- Change some website links
- Add a "redirect" link in the wiki
Other than that it looks good. I'll test this on ubuntu focal, just in case.
apyrgio
force-pushed
the
206-support-ubuntu-focal
branch
from
6717844 to
92b2bdb
Compare
|
Thanks for your suggestions. I incorporated them, so I'm good to merge when I have the ACK from you. |
|
LGTM |
Copy installation instructions from the Dangerzone wiki [1] into the Dangerzone source. This has several benefits: 1. Devs can update installation instructions as part of a PR. 2. Users can see installation instructions for previous releases. The last point is important, because we can update our instructions in the main branch, without affecting the instructions a user follows from the website (currently pointing to the Dangerzone Wiki). Refs #240 [1]: https://github.com/freedomofpress/dangerzone/wiki/Installing-Dangerzone
Report some Linux versions that were recently supported (Debian 12 / Fedora 37) in the installation instructions. These instructions where copied from the Dangerzone wiki, which is why the recently supported versions were missing.
Support Click version 7.x and below, which inspect the number of arguments a callback handler supports. Refs #206
Introduce a script for installing Podman in Ubuntu Focal, in environments that may, or may not, have sudo installed. Also, update our CircleCI configuration to use this script when installing Podman.
Add extra installations steps for installing Podman in Ubuntu Focal, since it's not present in the official Ubuntu repos. This is the final requirement to reinstate Ubuntu Focal support. Closes #206
Signed-off-by: Alex Pyrgiotis <[email protected]>
apyrgio
force-pushed
the
206-support-ubuntu-focal
branch
from
92b2bdb to
1147698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate support for Ubuntu Focal, by creating packages for it in our CI and providing some extra installation instructions to users.
Closes #206
Refs #240