-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generalized Code of Conduct for FPF repositories #1
Conversation
5d65eff
to
73d6927
Compare
The language looks great! Do we need this |
I think so - I suggest that we confirm that it works as expected first, and then codify the config. |
This looks good to me! |
I think this is an excellent idea, the language looks great on a first pass to me, but I'd love to take another pass over it. |
Big fan, let's give this a try. Thanks for creating, @eloquence! |
CODE_OF_CONDUCT.md
Outdated
of: | ||
|
||
- Harris Lapiroff (`@harrislapiroff`) - Principal Web Developer - [email protected] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should probably be at least 2 contacts for each subsection or a more generalized "community team" section for the entire org
|
||
- Conor Schaefer (`@conorsch`) - Chief Technology Officer - [email protected] | ||
- Erik Moeller (`@eloquence`) - Principal Project Manager - [email protected] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to volunteer myself as a point of contact for any of the groups that could use an extra person
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also happy to volunteer, as well. I've discussed this with a few folks in the past, and I'm still happy to offer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think we have enough people to make up a community team: Keturah, Harlo, Conor, Harris, and myself. @eloquence what do you think about making a section called "Community Team" with our names and emails (maybe links to our FPF profiles if you think that's helpful)? We can reference it on line 47 which is when the concept of a Community Team is introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a plan! :) Thanks much for organizing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 7e2c7e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a nit left to maybe link to the community team the first time it's referenced on line 47 if you agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, done in 76f1e66 :)
Moving this out of draft state since the general idea of having this as a global file seems to be welcome. Like @creviera did, I would encourage folks to nominate themselves or invite others to join a community team. If we keep the multi-tier structure, I would encourage us to keep an eye on the composition of the teams to ensure they're internally diverse (and am happy to remove myself from the list to make space for others). |
37529f2
to
1c1767e
Compare
1c1767e
to
7e2c7e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gorg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magnificent. Let's get this in, we'll file updates in other repos as required.
Per https://docs.github.com/en/github/building-a-strong-community/creating-a-default-community-health-file, this provides a default code of conduct for all repos under the
freedomofpress
umbrella.If this looks good and we can verify post-merge that it works as expected in repositories without a Code of Conduct, we could potentially remove the project-specific copies, reducing the maintenance workload.
In order to make the Code of Conduct generalizable, I had to update some language that was project-specific, and enumerate the points of contact for different projects (SecureDrop vs. web vs. everything else).
For now I've volunteered Conor and myself for the "everything else" category, but happy to update that as y'all see fit.