Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ice(4): Add host SR-IOV support #1573

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kgalazka
Copy link
Contributor

Allows creating Virtual Functions on E800 adapters with up to 16 queues.
Changing MAC address and using promiscuous mode for each VF
may be enabled in configuration.

Please be advised that this is still work in progress and may be unstable.

Authored-by: Eric Joyner [email protected]
Signed-off-by: Krzysztof Galazka [email protected]

Enable basic SR-IOV support for E800 adapters.

Authored-by: Eric Joyner <[email protected]>
Signed-off-by: Krzysztof Galazka <[email protected]>
Filter for unicast MAC address is configured
with a virtual channel message, but filter for
a broadcast traffic was missing. It caused
issues with e.g. ARP.

Signed-off-by: Krzysztof Galazka <[email protected]>
@concussious
Copy link
Contributor

Changing MAC address and using promiscuous mode for each VF may be enabled in configuration.

Would you be willing to update the manual page for this change?

@ricera
Copy link
Contributor

ricera commented Feb 7, 2025

If I was sufficiently motivated, I could maybe take a crack at it.

@kgalazka have you tried this on E830 devices? The last time I tried it didn't work; I don't know if it's worth calling out somewhere that it doesn't work on those since E830 hasn't been released yet, but I imagine once they are people will expect this to work on those and will be surprised that it mysteriously does not.

@@ -369,6 +369,14 @@ ice_iov_add_vf(struct ice_softc *sc, uint16_t vfnum, const nvlist_t *params)
goto release_imap;
}

/* Add the broadcast address */
error = ice_add_vsi_mac_filter(vsi, broadcastaddr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this here might mean that this doesn't get re-added after a reset, right? Though, I want to swear that broadcast promiscuous mode should be getting enabled on this VF VSI already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants