-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 282306: Update spelling of "non-zero" to "nonzero" for C23 compliance #1554
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional context:
"Society of Industrial and Applied Mathematics recommends that "non" as a prefix not be hyphenated".
~ https://gcc.gnu.org/legacy-ml/gcc/2001-10/msg00610.html
I read over all of these and made sure they looked reasonable.
If this is good to you, please ammend your commit message with reviewed by: ziaee
. Thank you, this is a very desirable change, to me!
Done. |
Sorry for my oversight, it should have |
…ance Note: This update excludes changes to contrib, cddl, and man pages originating outside of FreeBSD itself. PR: 282306 Reported by: kargl Reviewed by: ziaee Signed-off-by: Faraz Vahedi <[email protected]>
Done. |
@concussious you have commit access, right? Or do you need somebody else to commit this? |
Im pretty sure most of these are an incorrect application of this spelling. Specifically, returns nonzero is right, but non-zero number is also right because non modifies more than one word. |
@asomers If my mentors @sergio-carlavilla and/or @mhorne consent, then yes I can. However, I don't understand if @bsdimp is saying that we could but maybe shouldn't do this. |
C23 (ISO/IEC 9899:2024) standard specifies the spelling "nonzero" instead of "non-zero." This PR updates all occurrences of "non-zero" in the codebase (excluding man pages originating outside of FreeBSD itself) to align with the standard.
PR: 282306