Switch from using va_gen to va_filerev since its actually the correct attribute for this purpose #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 27, 2022 20:44
|
I gave this a quick test on a FreeBSD 13 box and it looks good. I merged it after fixing a trivial whitespace nit in pefs_getgen_and_filerev, squashing the commits together and changing the commit log to be clearer. Now to update the port :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
OpenZFS in FreeBSD 13.1 and up no no longer incorrectly updates va_gen when the file or directory is modified. This means that is no longer a reliable source to base a dircache invalidation on. Instead we should use va_filerev for that, which is based on the same value that va_gen (incorrectly) used to be based on prior to 13.1.