Fix/Improve Accessibilty Practices #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BerkeleyTrue
added
the
status: waiting review
| @@ -1691,91 +1695,6 @@ | |||
| "challengeType": 0 | |||
| }, | |||
| { | |||
| "id": "bad87fee1348bd9aedf08818", | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM. |
| @@ -990,6 +990,9 @@ | |||
| "You can add images to your website by using the <code>img</code> element, and point to a specific image's URL using the <code>src</code> attribute.", | |||
| "An example of this would be:", | |||
| "<code><img src=\"https://www.your-image-source.com/your-image.jpg\"></code>", | |||
| "All <code>img</code> elements MUST have an <code>alt</code> attribute. The text inside an <code>alt</code> attribute is used for screen-readers and is displayed if the image fails to load.", | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@Bouncey updated the pull request. |
| @@ -1066,6 +1066,9 @@ | |||
| "You can add images to your website by using the <code>img</code> element, and point to a specific image's URL using the <code>src</code> attribute.", | |||
| "An example of this would be:", | |||
| "<code><img src=\"https://www.your-image-source.com/your-image.jpg\"></code>", | |||
| "All <code>img</code> elements <strong>must</strong> have an <code>alt</code> attribute. The text inside an <code>alt</code> attribute is used for screen readers to improve accessibility and is displayed if the image fails to load.", | |||
| "Lets add an <code>alt</code> attribute to our <code>img</code> example above:", | |||
| "<code><img src=\"https://www.your-image-source.com/your-image.jpg\" alt=\"Author standing on a beach with two thumbs up. \">", | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@Bouncey any updates? |
bugron
added
status: blocked
|
@Bouncey updated the pull request. |
|
Please QA |
raisedadead
added
status: waiting review
|
@Bouncey thanks. |
raisedadead
removed
the
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of FreeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm run test-challenges. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
Reference issue #4656
Integrated the
altattribute throughout all challenges that use theimgelement.Removed the
Add Alt Text to an Image for Accessibilitychallenge. It becomes redundant due to this PR.