Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #8686

Closed
wants to merge 33 commits into from
Closed

Patch 1 #8686

wants to merge 33 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • [ x] Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Berkeley Martinez and others added 30 commits February 29, 2016 12:43
@camperbot
Copy link
Contributor

@willnwhite thanks for the PR.
Your branch name should start with one of fix/, feature/, translate/ prefixes. Name, your branches correctly next time, please.
You have pushed more than one commit. When you finish editing, squash your commits into one.
Please, review our Guidelines for Contributing, thank you!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants