Adjusting wording in "Friendly Date Ranges" bonfire #7978
Conversation
| "Do not display information that is redundant or that can be inferred by the user: if the date range ends in less than a year from when it begins, do not display the ending year. If the range ends in the same month that it begins, do not display the ending year or month.", | ||
| "Additionally, if the date range begins in the current year and ends within one year, the year should not be displayed at the beginning of the friendly range.", | ||
| "Do not display information that is redundant or that can be inferred by the user: if the date range ends in less than a year from when it begins, do not display the <em>ending year<em>. If the range ends in the same month that it begins, do not display the <em>ending year or month<em>.", | ||
| "Additionally, if the date range begins in the <em>current year<em> and ends within one year, the year should not be displayed at the <em>beginning<em> of the friendly range.", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
erictleung
added
status: waiting review
|
@josectello updated the pull request. |
|
Hmm I just realized my suggestion was a little inconsistent in what is emphasized. If you don't mind @josectello, could you change it to what is below? I tried bolding the changes but it might be a little hard to see. Also from #7967, there are a comment on changing the order of the sentence flow better. Can you more around the sentences to match the order as well? Let me know if you have any questions. Thanks!
|
|
@josectello updated the pull request. |
|
@erictleung No worries, thanks for the input. Let me know if anything else needs adjusting. |
…tween test cases for "Friendly Date Ranges" challenge.
|
@josectello LGTM 👍 |
BerkeleyTrue
removed
status: blocked
Adjust wording on lines 268-269 to clarify differences between test cases for "Friendly Date Ranges" bonfire in advanced-bonfires.json. This closes #7967.