Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runic breaks unpacking of only the first element of a tuple #58

Closed
efaulhaber opened this issue Sep 9, 2024 · 0 comments · Fixed by #59
Closed

Runic breaks unpacking of only the first element of a tuple #58

efaulhaber opened this issue Sep 9, 2024 · 0 comments · Fixed by #59

Comments

@efaulhaber
Copy link 

julia> Runic.format_string("x, = (1, 2, 3)")
"x = (1, 2, 3)"

That is, of course, not equivalent:

julia> x, = (1, 2, 3); x
1

julia> x = (1, 2, 3); x
(1, 2, 3)
@efaulhaber efaulhaber mentioned this issue Sep 9, 2024
Draft
@efaulhaber efaulhaber changed the title Unpacking of the first element gets changed into non-equivalent code by Runic Runic breaks unpacking of only the first element of a tuple Sep 9, 2024
fredrikekre added a commit that referenced this issue Sep 9, 2024
@fredrikekre
Fix trailing comma in implicit tuples in destructuring
959fccc 
This patch fixes the usage of trailing commas in implicit tuples when
used in destructuring assignment, e.g. `x, = z`. In this context the
trailing comma is needed to preserve the tuple node, which is different
from e.g. implicit tuples in `do`-blocks. A trailing comma is allowed
(e.g. preserved from the source) for multi-item implicit tuples so that
e.g. `x, y, = z` can be used to signal that z contains more than two
items. Closes #58.
@fredrikekre fredrikekre mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix trailing comma in implicit tuples in destructuring fredrikekre/Runic.jl
1 participant
@efaulhaber