-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to cli-table3 #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielRuf It seems that a typo came in to the PR. I guess it should read cli-table3
both places.
src/cli/console.js
Outdated
@@ -3,7 +3,7 @@ | |||
const Promise = require('bluebird'); | |||
const _ = require('lodash'); | |||
const chalk = require('chalk'); | |||
const Table = require('cli-table2'); | |||
const Table = require('cli-table5'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a 3 instead of a 5? Seems to be the reason that Travis fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, fixed it.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump. |
Hi @DanielRuf, would you mind updating this PR against master? We've updated Travis to Node LTS versions so it would be good to make sure that CI can pass in the newer versions. Thank you! |
Done. |
Resolved by #466 |
No description provided.