Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to cli-table3 #443

Closed
wants to merge 1 commit into from
Closed

chore: migrate to cli-table3 #443

wants to merge 1 commit into from

Conversation

DanielRuf
Copy link
Contributor

No description provided.

Copy link

@jonasdk jonasdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRuf It seems that a typo came in to the PR. I guess it should read cli-table3 both places.

@@ -3,7 +3,7 @@
const Promise = require('bluebird');
const _ = require('lodash');
const chalk = require('chalk');
const Table = require('cli-table2');
const Table = require('cli-table5');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a 3 instead of a 5? Seems to be the reason that Travis fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, fixed it.

@stale
Copy link

stale bot commented Sep 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Sep 3, 2018
@DanielRuf
Copy link
Contributor Author

Bump.

@stale stale bot removed the inactive label Sep 3, 2018
@dkhuntrods
Copy link
Member

Hi @DanielRuf, would you mind updating this PR against master? We've updated Travis to Node LTS versions so it would be good to make sure that CI can pass in the newer versions. Thank you!

@DanielRuf
Copy link
Contributor Author

Hi @DanielRuf, would you mind updating this PR against master?

Done.

@dkhuntrods
Copy link
Member

Resolved by #466

@dkhuntrods dkhuntrods closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants