Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(partner): Remove legacy contract check #2441

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

shadrak98
Copy link
Contributor

  • Remove redundant code block from Invoice
  • Fetch certificate count of partner

* Remove redundant code block from Invoice
* Fetch certificate count of partner
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.30%. Comparing base (4a5731e) to head (3a6a6fa).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
press/api/partner.py 0.00% 3 Missing ⚠️
press/press/doctype/team/team.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2441      +/-   ##
==========================================
- Coverage   38.34%   38.30%   -0.05%     
==========================================
  Files         378      379       +1     
  Lines       29738    29784      +46     
==========================================
+ Hits        11404    11409       +5     
- Misses      18334    18375      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadrak98 shadrak98 merged commit a89d18b into frappe:master Jan 23, 2025
7 of 8 checks passed
@shadrak98 shadrak98 deleted the fix_partner_discount branch January 23, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant