Fix: loan repayment via fnf #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyshaHakeem
requested review from
nabinhait and
deepeshgarg007
and removed request for
ruchamahabal
| if loan_repayment_schedule.repayment_schedule: | ||
| amounts = [] | ||
| for repayment_schedule in loan_repayment_schedule.repayment_schedule: | ||
| amounts = calculate_amounts(loan, doc.transaction_date, "Normal Repayment") |
There was a problem hiding this comment.
Amounts should ideally be fetched once the accrual is done
deepeshgarg007
added a commit
that referenced
this pull request
Jan 28, 2025
…2643 Fix: loan repayment via fnf (backport #2643)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle receivable loans included in the Full and Final (FnF) statement, if any, upon its submission: