Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove branding - favicon & custom name #1526

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Aug 23, 2023

Don't use brand_favicon and helpdesk_name!

Branding helps in customisation but it breaks product integrity. From this PR on, its not possible to have custom favicon and name. Custom logo can be used but will be removed at a later stage

closes: #1524

ssiyad added 2 commits August 23, 2023 18:00
- all main pages (accessible from sidebar)
- ticket (agent portal)
@ssiyad ssiyad added enhancement New feature or request breaking-change labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (464bbb6) 2.74% compared to head (732c742) 2.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1526   +/-   ##
=====================================
  Coverage   2.74%   2.74%           
=====================================
  Files         56      56           
  Lines       1640    1640           
=====================================
  Hits          45      45           
  Misses      1595    1595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad merged commit 4b6c53c into frappe:main Aug 23, 2023
@ssiyad ssiyad deleted the chore/rm_branding branch August 23, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show ticket title in browser tab
1 participant