Update phpstan #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
update_phpstan
branch
from
93398c6 to
6e37360
Compare
franmomu
force-pushed
the
update_phpstan
branch
2 times, most recently
from
3e6c5e1 to
a2de76e
Compare
The phpstan version used (0.10.x) does not work with the error formatter, this just removes it and it will be added in another commit upgrading PHPStan.
Codecov Report
@@ Coverage Diff @@
## 2.1.x #5 +/- ##
=========================================
Coverage 82.12% 82.12%
Complexity 3835 3835
=========================================
Files 128 128
Lines 8630 8631 +1
=========================================
+ Hits 7087 7088 +1
Misses 1543 1543
Continue to review full report at Codecov.
|
Remove phpstan error formatter
An exception is thrown in the line above.
franmomu
force-pushed
the
update_phpstan
branch
from
a2de76e to
165cb9e
Compare
The current return types did not comply with PersistentCollectionInterface.
The phpdoc did not match the current return and arguments types.
The check removed was impossible to be true since the argument has a type declaration.
The ReferencePrimer::parseDotSyntaxForPrimer had a case which there was no return and the function has to return an array or Traversable.
At the beginning of the method, "$this->queuedInserts" is checked if it is empty, if it is not, "$inserts" variable will always have some value and the "if" removed is always true.
franmomu
force-pushed
the
update_phpstan
branch
from
165cb9e to
e718fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.