Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore function evaluations that return Inf (or NaN) #19

Closed
pcjentsch opened this issue Jul 9, 2020 · 2 comments · Fixed by #20
Closed

Ignore function evaluations that return Inf (or NaN) #19

pcjentsch opened this issue Jul 9, 2020 · 2 comments · Fixed by #20

Comments

@pcjentsch
Copy link

When I train ODE models, some parameter combinations tend to cause the solution to be too stiff, which causes the solver to exit early and return an error.

Usually, when this happens I return a cost of Inf and which regular parameter optimization, the solution is ignored.

However, for some of the Bayesian parameter estimation algorithms that value is kept and it seems to prevent the algorithm from converging (range_\epsilon = (x, Inf)` for instance).

Would it be possible to add a mode that just discards that point?

Thank you

francescoalemanno added a commit that referenced this issue Jul 9, 2020
@francescoalemanno
Copy link
Owner

i'm working on a PR that could fix this issue, can you try the branch fix19 on your problems to see if it helps?

francescoalemanno added a commit that referenced this issue Jul 10, 2020
* fix for issue #19
* docs update and code formatting
@pcjentsch
Copy link
Author

The fix seems to work, thanks I appreciate it. I am still using v1.3.0 for my research at the moment as it seems to give better performance. Increasing the burnin as you mentioned in the forum does help, but it takes much longer to get similarly tight posterior distributions in my problem with v2.0. I have around 17 variables at the moment, though, so many there is another parameter I should tweak?

francescoalemanno added a commit that referenced this issue Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants