feat: expose onSignature callbacks for eth_signTypedData_v4 requests #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
normanzb
commented
Jan 24, 2025
| @@ -325,6 +331,7 @@ export function useFrame< | |||
| homeframeUrl, | |||
| signerState.hasSigner, | |||
| signerState.signer, | |||
| onErrorRef, | |||
There was a problem hiding this comment.
got a eslint warning here about missing dep, since it is ref it should be fine to be included.
normanzb
force-pushed
the
fix/missing-onsig
branch
from
3aac19c to
c9c52a5
Compare
normanzb
commented
Jan 27, 2025
| @@ -12,20 +12,224 @@ import { SignerStateInstance } from "@frames.js/render"; | |||
| import type { | |||
There was a problem hiding this comment.
this is a direct copy paste of the module, in the doc it is very out dated
normanzb
force-pushed
the
fix/missing-onsig
branch
from
8cc49fd to
0fa5f34
Compare
stephancill
approved these changes
Jan 27, 2025
normanzb
force-pushed
the
fix/missing-onsig
branch
from
0fa5f34 to
f048495
Compare
normanzb
force-pushed
the
fix/missing-onsig
branch
from
f048495 to
b4aa15d
Compare
michalkvasnicak
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
onSignatureXXX callbacks will be triggered when the frame server request for signing for typed data (
eth_signTypedData_v4).However previous these callbacks are not exposed via
useFrame()Merge Checklist