feat: application error support #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| */ | ||
| constructor(message: string, status: number) { | ||
| if (message.length > 90) throw new Error("Message too long"); | ||
| if (status < 400 || status >= 500) throw new Error("Invalid status code"); |
There was a problem hiding this comment.
we don't allow 500?
There was a problem hiding this comment.
not allowed by the spec
https://warpcast.notion.site/Frames-Errors-ddc965b097d44d9ea03ddf98498597c6
There was a problem hiding this comment.
ah ok, still weird decision but I understand that this is for UI feedback as well.
There was a problem hiding this comment.
It is little confusing because people could use it to return 500. Is that a way to disallow 500 at least on type level?
michalkvasnicak
approved these changes
Apr 4, 2024
michalkvasnicak
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds support for application errors
Merge Checklist