fix: debugger initial frame load + frame ui image loading state on change #279
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michalkvasnicak
changed the title
packages/debugger/app/page.tsx
Outdated
| url || process.env.NEXT_PUBLIC_HOST || "http://localhost:3000" | ||
| ); | ||
| const url = useMemo(() => { | ||
| const fallbackURL = process.env.NEXT_PUBLIC_HOST || 'http://localhost:3000'; |
There was a problem hiding this comment.
Usually a client side exception occurs when a server isn't running - does this handle that?
There was a problem hiding this comment.
No, this just solves issues with manipulating the URL and also loading the URL on initial load. Not sure what you mean by exceptions.
There was a problem hiding this comment.
This doesn't fix an issue when frames return 500. Now I found out that when the URL is not alive our debugger returns 500 response which causes the debugger to fails as well with the following.
There was a problem hiding this comment.
Did you mean this @stephancill ?
There was a problem hiding this comment.
But then we should probably not fill the URL input with default URL as well right?
There was a problem hiding this comment.
i think it's useful to pre-populate the input, no?
There was a problem hiding this comment.
ok so if the url query is filled, we should load it automatically. If there is no url query param, then we should just show topbar, right?
|
lgtm! |
Change Summary
This PR fixes:
This PR also removes unnecessary url input state, etc.
Merge Checklist