Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-33: Remove nullable-temporal logic #38

Merged
merged 2 commits into from
Feb 11, 2022
Merged

ISSUE-33: Remove nullable-temporal logic #38

merged 2 commits into from
Feb 11, 2022

Conversation

fraenky8
Copy link
Owner

@fraenky8 fraenky8 commented Jan 29, 2022 •
edited
Loading

This PR does the following:

  • Removes the database specific nullable-time type and uses sql.NullTime now everywhere.
  • Removes unnecessary logic.
  • Removes unused interface methods.

**This PR is based on #37 - lets wait to be merged first. ✅ **

@fraenky8 fraenky8 self-assigned this Jan 29, 2022
@fraenky8 fraenky8 added the wip - do not merge Work In Progress label Jan 29, 2022
@fraenky8 fraenky8 removed the wip - do not merge Work In Progress label Feb 11, 2022
@fraenky8 fraenky8 merged commit 58b2740 into master Feb 11, 2022
@fraenky8 fraenky8 deleted the ISSUE-33 branch February 11, 2022 10:22
@fraenky8 fraenky8 mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fraenky8 fraenky8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fraenky8