Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PATCH user settings bulk-endpoint for user group #1936

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Oct 16, 2024

closes #1933

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 16, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.9 0.89 0.0 0.0
job 0.8 1.0 0.80 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 10.7 0.97 0.6 0.6
power 393.2 401.7 0.98 366.2 366.2
dataset 149.9 149.6 1.00 134.0 134.0
project 48.4 47.8 1.01 47.2 47.2
job 27.6 27.3 1.01 32.4 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.1 6.7 1.06 2.2 2.2
power 141.6 139.6 1.01 652.4 652.4
dataset 140.6 141.1 1.00 905.6 905.6
project 47.5 50.1 0.95 283.9 283.9
job 40.2 39.5 1.02 225.0 225.0

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.1 8.5 0.95 0.1 0.1
power 8.2 8.3 0.99 0.1 0.1
dataset 8.1 8.2 0.99 0.1 0.1
project 10.8 10.1 1.07 2.3 2.3
job 8.1 8.3 0.98 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 6.8 0.97 0.8 0.8
power 6.3 6.9 0.91 0.8 0.8
dataset 6.7 7.3 0.92 0.8 0.8
project 6.3 7.0 0.90 0.8 0.8
job 6.5 6.5 1.00 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.7 7.9 0.97 1.4 1.4
power 7.4 7.9 0.94 1.4 1.4
dataset 7.4 7.9 0.94 1.4 1.4
project 7.6 8.1 0.94 1.4 1.4
job 8.0 7.9 1.01 1.4 1.4

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.6 13.1 0.96 0.8 0.8
power 26.1 28.0 0.93 29.1 29.1
dataset 20.3 21.4 0.95 16.7 16.7
project 24.3 24.7 0.98 21.0 21.0
job 12.0 16.6 0.72 0.8 0.8

POST /api/v2/project/3/dataset/411/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 150.7 159.3 0.95 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.1 6.4 0.80 0.2 0.2
power 4.9 6.4 0.77 0.2 0.2
dataset 4.9 6.4 0.77 0.2 0.2
project 4.9 6.2 0.79 0.2 0.2
job 4.9 6.0 0.82 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.2 263.7 1.00 0.2 0.2

Copy link

github-actions bot commented Oct 16, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/auth
  group.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit 72a3da6 into main Oct 17, 2024
@ychiucco ychiucco deleted the 1933-introduce-patch-settings-endpoint-for-usergroup branch October 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce PATCH-settings endpoint for usergroup
2 participants